[PM-12571][PM-13807] Add/Edit Folder Dialog

[nick-livefront]

🎟️ Tracking

PM-12571
PM-13807

📔 Objective

• Moves AddEditFolderDialogComponent to @bitwarden/angular/vault/components so it can be used by both the browser and web
  • Adds AddEditFolderDialogResult enum so the web vault can redirect when a folder is deleted.
• Integrates the AddEditFolderDialogComponent to the web vault.
• Adds add/edit copy to the web messages file
• Fixes strict types on touched files
• Fixes missing hover border on delete icon button (PM-13807)

📸 Screenshots

Add/Edit/Delete folder on the web
Screen.Recording.2024-12-19.at.2.23.10.PM.mov

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 2a2c8705-3139-4517-8ad2-cd6be07d3865

Great job, no security vulnerabilities found in this Pull Request

[shane-melton]

Looks great! Just a few non-blocking suggestions/nits and one file move request.

[shane-melton]

Looks good, nice work!

[shane-melton]

I believe the failing tests should start working again after a merge with main. (we had some flaky date based tests that needed to be fixed for the new year)

[codecov]

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (ca53ecc) to head (3c1762c).
Report is 26 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/app/vault/individual-vault/vault.component.ts	0.00%	6 Missing ⚠️
...-folder-dialog/add-edit-folder-dialog.component.ts	76.47%	1 Missing and 3 partials ⚠️
...ew-item-dropdown/new-item-dropdown-v2.component.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12487   +/-   ##
=======================================
  Coverage   35.48%   35.49%           
=======================================
  Files        3007     3007           
  Lines       90899    90906    +7     
  Branches    16908    16909    +1     
=======================================
+ Hits        32260    32264    +4     
- Misses      56137    56138    +1     
- Partials     2502     2504    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nick-livefront]

Fixed conflicts from main, @shane-melton re-requesting review!

[nick-livefront]

@shane-melton @gbubemismith Brad realized that the full folder name was not being populated in the web vault. This was caused by the folder name being broken down into parts to be shown in the nested format.

I added the fullName property to the FolderFilter type so the edit dialog can reference the full name rather than just the last part.

706c388, b16fe41, 70bd316

[nick-livefront]

@gbubemismith Kyra found a slight bug that when editing the folder, the full name was displayed in the filter menu. This was caused from editing the folder object directly which then altered the same object that the filter menu was looking at.

I used a shallow copy that is then passed to the edit dialog

Before	After
folder-edit-before.mov	folder-edit-after.mov