Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16664] Incorrect price value in "add new organization" modal #12710

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jan 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16664

📔 Objective

  • The price for Enterprise shows as $72/month per member. It should show as $6/month per member.
  • Applied TypeScript strict rules.
  • Minimum seats now defaults to '1' which is the lowest value for the given validation rules.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 6, 2025 10:28
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Logo
Checkmarx One – Scan Summary & Details19568b87-3870-403a-93fa-dd5e3612cd83

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/attachments.component.ts: 37 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/password-history.component.ts: 23 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/vault/src/components/decryption-failure-dialog/decryption-failure-dialog.component.html: 17
LOW Client_JQuery_Deprecated_Symbols /apps/browser/src/background/runtime.background.ts: 94

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (196c1e1) to head (cc2463a).
Report is 215 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...roviders/clients/create-client-dialog.component.ts 0.00% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12710      +/-   ##
==========================================
+ Coverage   33.74%   34.13%   +0.39%     
==========================================
  Files        2918     2937      +19     
  Lines       90994    90356     -638     
  Branches    17200    16968     -232     
==========================================
+ Hits        30703    30846     +143     
+ Misses      57891    57055     -836     
- Partials     2400     2455      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx added the needs-qa Marks a PR as requiring QA approval label Jan 6, 2025
cyprain-okeke
cyprain-okeke previously approved these changes Jan 6, 2025
@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud January 8, 2025 03:38 Inactive
@jonashendrickx jonashendrickx removed the needs-qa Marks a PR as requiring QA approval label Jan 22, 2025
@jonashendrickx jonashendrickx merged commit 8784602 into main Jan 22, 2025
40 of 41 checks passed
@jonashendrickx jonashendrickx deleted the PM-16664 branch January 22, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants