Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718

Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
98f45e9
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
a570803
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
84edfc0
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
0a28e6a
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
acb0931
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
ec28e7b
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 8, 2025
317c197
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 8, 2025
322ed11
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 8, 2025
a2b2d71
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 9, 2025
a49ae00
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 14, 2025
6417c7f
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 14, 2025
3e153ba
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 14, 2025
29f09a0
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 15, 2025
454a798
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 15, 2025
c57d38e
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 15, 2025
e8da9fa
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 16, 2025
f7672e4
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
…on - Rolled back typo fixes.
Patrick-Pimentel-Bitwarden committed Jan 6, 2025
commit 84edfc0cd8c5874ea9298cc8ba55aeb6ee147d0e
4 changes: 2 additions & 2 deletions apps/desktop/src/auth/login/login-v1.component.ts
Original file line number Diff line number Diff line change
@@ -191,7 +191,7 @@ export class LoginComponentV1 extends BaseLoginComponent implements OnInit, OnDe
if (!this.formGroup.controls.email.valid) {
this.toastService.showToast({
variant: "error",
title: this.i18nService.t("errorOccurred"),
title: this.i18nService.t("errorOccured"),
message: this.i18nService.t("invalidEmail"),
});
return;
@@ -247,7 +247,7 @@ export class LoginComponentV1 extends BaseLoginComponent implements OnInit, OnDe
} catch (err) {
this.platformUtilsService.showToast(
"error",
this.i18nService.t("errorOccurred"),
this.i18nService.t("errorOccured"),
this.i18nService.t("ssoError"),
);
}

Unchanged files with check annotations Beta

FakeKeyConnectorUserDecryptionOption as KeyConnectorUserDecryptionOption,
LoginStrategyServiceAbstraction,
FakeTrustedDeviceUserDecryptionOption as TrustedDeviceUserDecryptionOption,
FakeUserDecryptionOptions as UserDecryptionOptions,

Check failure on line 11 in libs/angular/src/auth/components/sso.component.spec.ts

GitHub Actions / Test Results

SsoComponent ► SsoComponent logIn(...) Set Master Password scenarios Given user needs to set a master password navigates to the component's defined change password route when onSuccessfulLoginChangePasswordNavigate callback is undefined ► SsoComponent ...

Failed test found in: junit.xml Error: Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)
Raw output
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

- Expected
+ Received

  Array [
-   "set-password",
+   "set-password-jit",
  ],
  {"queryParams": {"identifier": "orgIdFromState"}},

Number of calls: 1
    at /home/runner/work/clients/clients/libs/angular/src/auth/components/sso.component.spec.ts:310:37
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/clients/clients/libs/angular/src/auth/components/sso.component.spec.ts:11:58)
    at _ZoneDelegate.invoke (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:416:32)
    at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone-testing.umd.js:2176:43)
    at _ZoneDelegate.invoke (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:415:38)
    at ZoneImpl.run (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:147:47)
    at /home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:2598:42
    at _ZoneDelegate.invokeTask (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:449:37)
    at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvokeTask (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone-testing.umd.js:2207:43)
    at _ZoneDelegate.invokeTask (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:448:42)
    at ZoneImpl.runTask (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:196:51)
    at drainMicroTaskQueue (/home/runner/work/clients/clients/node_modules/zone.js/bundles/zone.umd.js:638:39)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
UserDecryptionOptionsServiceAbstraction,
} from "@bitwarden/auth/common";
import { ApiService } from "@bitwarden/common/abstractions/api.service";