Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14921]Customers managed by a Reseller need to see how many seats are in their subscription, while still obfuscating the cost of subscription. #12726

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14921

📔 Objective

Customers who are now being added as a Reseller Managed Account in our new system can no longer see the amount of seats they are paying for, or how many seats they have active.

The result would be to allow those account owners to see their number of active seats and purchase seats, while still obfuscating the billing details to ensure the Reseller pricing is not available.

📸 Screenshots

Screen.Recording.2025-01-07.at.13.32.38.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner January 7, 2025 12:41
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One – Scan Summary & Detailscbe8f3d8-114e-467a-96c1-02a7abab229c

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.29%. Comparing base (c3bb76b) to head (aa6ed2b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tions/organization-subscription-cloud.component.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12726   +/-   ##
=======================================
  Coverage   35.28%   35.29%           
=======================================
  Files        2997     2997           
  Lines       90873    90880    +7     
  Branches    16966    16968    +2     
=======================================
+ Hits        32067    32074    +7     
  Misses      56318    56318           
  Partials     2488     2488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants