Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13028] - align default globe vault icon with cipher icons #12786

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13028

๐Ÿ“” Objective

This PR aligns the default globe icon with the cipher icons.

๐Ÿ“ธ Screenshots

Before After
Screenshot 2025-01-09 at 10 11 00โ€ฏAM Screenshot 2025-01-09 at 10 06 53โ€ฏAM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 9, 2025 18:14
@jaasen-livefront jaasen-livefront changed the title [PM-13028] - align default globe vault icon [PM-13028] - align default globe vault icon with cipher icons Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f66908e4-9a3b-436c-a840-7f1c63f29527

No New Or Fixed Issues Found

@jaasen-livefront jaasen-livefront merged commit 8a0ebd9 into main Jan 13, 2025
87 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-13028-2 branch January 13, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants