Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14422] Vault Carousel #12791

Merged
merged 28 commits into from
Jan 22, 2025

remove rem calculation

fc01259
Select commit
Loading
Failed to load commit list.
Merged

[PM-14422] Vault Carousel #12791

remove rem calculation
fc01259
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

34.44% (+0.00%) compared to 3917f50

View this Pull Request on Codecov

34.44% (+0.00%) compared to 3917f50

Details

Codecov Report

Attention: Patch coverage is 81.15942% with 13 lines in your changes missing coverage. Please review.

Project coverage is 34.44%. Comparing base (3917f50) to head (fc01259).
Report is 18 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../vault/src/components/carousel/carousel.stories.ts 0.00% 9 Missing โš ๏ธ
...ault/src/components/carousel/carousel.component.ts 94.11% 2 Missing โš ๏ธ
...arousel/carousel-slide/carousel-slide.component.ts 87.50% 0 Missing and 1 partial โš ๏ธ
libs/vault/src/components/carousel/index.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #12791    +/-   ##
========================================
  Coverage   34.44%   34.44%            
========================================
  Files        2974     2990    +16     
  Lines       90667    90828   +161     
  Branches    16989    16996     +7     
========================================
+ Hits        31233    31289    +56     
- Misses      56968    57072   +104     
- Partials     2466     2467     +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.