[PM-16926] Fix KM bad imports #12807
Open
+131
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Avery
commented
Jan 10, 2025
| @@ -7,7 +7,7 @@ export { BiometricsCommands } from "./biometrics/biometrics-commands"; | |||
| export { BiometricsService } from "./biometrics/biometric.service"; | |||
| export * from "./biometrics/biometric.state"; | |||
|
|
|||
| export { KeyService } from "./abstractions/key.service"; | |||
| export { KeyService, CipherDecryptionKeys } from "./abstractions/key.service"; | |||
There was a problem hiding this comment.
Needed to add CipherDecryptionKeys for the test file libs/common/src/vault/services/cipher.service.spec.ts
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12807 +/- ##
=======================================
Coverage 34.36% 34.36%
=======================================
Files 2952 2952
Lines 90458 90458
Branches 16977 16977
=======================================
Hits 31088 31088
Misses 56906 56906
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
Thomas-Avery
requested review from
addisonbeck,
nick-livefront and
ike-kottlowski
ike-kottlowski
previously approved these changes
Jan 10, 2025
nick-livefront
previously approved these changes
Jan 10, 2025
mzieniukbw
previously approved these changes
Jan 10, 2025
addisonbeck
previously approved these changes
Jan 14, 2025
Thomas-Avery
dismissed stale reviews from addisonbeck, mzieniukbw, nick-livefront, and ike-kottlowski
via
e3ddef6
Thomas-Avery
requested review from
mzieniukbw,
nick-livefront,
addisonbeck and
ike-kottlowski
mzieniukbw
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16926
📔 Objective
The purpose of this PR is to fix bad imports identified in #12744.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes