-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17035] Fix biometric unlock badge in mv2 #12854
Conversation
New Issues (12)Checkmarx found the following issues in this Pull Request
Fixed Issues (2)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12854 +/- ##
==========================================
- Coverage 34.29% 34.29% -0.01%
==========================================
Files 2935 2935
Lines 90237 90247 +10
Branches 16945 16948 +3
==========================================
Hits 30951 30951
- Misses 56822 56832 +10
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
Oh, seems the fix-autoprompt on firefox pr was targeting this branch. That's fine though, since both have been QA'd and are approved for merge/cherry-pick. |
b4b7900
Resolved merge conflicts. |
* Fix biometrics not working in firefox or windows * Remove logs * Update badge after biometric unlock * Add removal todo note * Remove debug logging * Fix type warnings * Fix userkey typing in background biometrics service * Simplify types for userkey in foreground-browser-biometrics and runtime.background.ts * Add process reload logging * Fix autoprompt not working when no process reload happened * Fix biometric unlock badge in mv2 * Fix instant reprompt on firefox lock * Remove biometrics autoprompt on firefox (#12856) (cherry picked from commit a5dce05)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17035
📔 Objective
For whatever reason, main.background.ts only updates the badge on:
This PR forces a switchaccount call, after setting the userkey, such that the actions that main.background.ts does are performed. These are:
Note: It is unclear to me whether this is the intended method to have the badge refreshed.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes