Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CSS classes that aren't tailwind-compatible #12871

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

audreyality
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-17089

๐Ÿ“” Objective

Clean up CSS classes that aren't tailwind-compatible so that tailwind lints can be enabled.

These classes have no effect on the UI; there aren't updated screenshots.

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner January 14, 2025 20:54
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 0f1172e8-0295-4a8d-9a65-8de63f89db46

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.27%. Comparing base (0456648) to head (374018a).
Report is 9 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12871      +/-   ##
==========================================
- Coverage   34.28%   34.27%   -0.01%     
==========================================
  Files        2935     2935              
  Lines       90229    90229              
  Branches    16943    16943              
==========================================
- Hits        30937    30930       -7     
- Misses      56828    56835       +7     
  Partials     2464     2464              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@audreyality audreyality merged commit bbf1287 into main Jan 15, 2025
84 checks passed
@audreyality audreyality deleted the tools/pm-17089/remove-css-classes-from-components branch January 15, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants