Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15200] first pass at "generated credential" screen reader notifications #12877

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

audreyality
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15200

๐Ÿ“” Objective

Notify users with screen readers when a new credential is generated.

๐Ÿ“ธ Screenshots

N/A

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ ffb4e5eb-c74e-4862-982c-92fdebcb72d7

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 15
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.45%. Comparing base (70cf459) to head (7023e0a).

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12877   +/-   ##
=======================================
  Coverage   34.44%   34.45%           
=======================================
  Files        2974     2974           
  Lines       90667    90667           
  Branches    16989    16989           
=======================================
+ Hits        31233    31240    +7     
+ Misses      56968    56961    -7     
  Partials     2466     2466           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant