Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17064] Prevent error being thrown when taxInformation is undefined. #12884

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17064

📔 Objective

After creating a free organization, and configuring a payment method, if we are to try to upgrade the organization to either Families, Teams or Enterprise, we're getting a 500 error back.

This pull request fixes an unrelated error where taxInformation could be undefined in the component, and throw an error.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 15, 2025 11:24
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.29%. Comparing base (55e4b5e) to head (7770938).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ling/organizations/change-plan-dialog.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12884      +/-   ##
==========================================
- Coverage   34.30%   34.29%   -0.01%     
==========================================
  Files        2935     2935              
  Lines       90236    90237       +1     
  Branches    16944    16945       +1     
==========================================
  Hits        30951    30951              
- Misses      56821    56822       +1     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cturnbull-bitwarden cturnbull-bitwarden merged commit ee6822c into main Jan 15, 2025
38 of 39 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the PM-17064 branch January 15, 2025 15:05
cturnbull-bitwarden pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants