Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16984] Improve type safety in decryption #12885

Open
wants to merge 1 commit into
base: km/improve-logging
Choose a base branch
from

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16984

📔 Objective

Domain and View objects needs to have the same keys of the string or EncString type.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw changed the base branch from main to km/improve-logging January 15, 2025 13:25
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb651c0a2-ac9d-4500-accc-8631f0ba377a

New Issues (13)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2025-0436 Npm-electron-33.2.1 Vulnerable Package
CRITICAL CVE-2025-0438 Npm-electron-33.2.1 Vulnerable Package
CRITICAL CVE-2025-0439 Npm-electron-33.2.1 Vulnerable Package
CRITICAL CVE-2025-0443 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0434 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0435 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0437 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0446 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0440 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0441 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0442 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0447 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0448 Npm-electron-33.2.1 Vulnerable Package

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.29%. Comparing base (3f4809c) to head (a175bce).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           km/improve-logging   #12885      +/-   ##
======================================================
+ Coverage               34.13%   34.29%   +0.16%     
======================================================
  Files                    2936     2935       -1     
  Lines                   90427    90219     -208     
  Branches                16991    16942      -49     
======================================================
+ Hits                    30864    30942      +78     
+ Misses                  57105    56813     -292     
- Partials                 2458     2464       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzieniukbw mzieniukbw marked this pull request as ready for review January 15, 2025 14:02
@mzieniukbw mzieniukbw requested review from a team as code owners January 15, 2025 14:02
Copy link
Collaborator

@nick-livefront nick-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Running through the vault, changes look good. Love the improved typing, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants