[PM-15637] Configure deepLinkGuard in OrganizationsModule for Device Approval Links #12890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
…ice-approval-requests
…ice-approval-requests
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12890 +/- ##
=======================================
Coverage 35.24% 35.25%
=======================================
Files 2997 2997
Lines 90886 90887 +1
Branches 16973 16973
=======================================
+ Hits 32034 32041 +7
+ Misses 56364 56358 -6
Partials 2488 2488 ☔ View full report in Codecov by Sentry. |
BTreston
approved these changes
Jan 16, 2025
…ice-approval-requests
r-tome
commented
Jan 23, 2025
| @@ -18,7 +19,7 @@ const routes: Routes = [ | |||
| { | |||
| path: "organizations/:organizationId", | |||
| component: OrganizationLayoutComponent, | |||
| canActivate: [authGuard, organizationPermissionsGuard()], | |||
| canActivate: [deepLinkGuard(), authGuard, organizationPermissionsGuard()], | |||
There was a problem hiding this comment.
@eliykat, I couldn't make deepLinkGuard dependent on the device approval emails feature flag. Is it still safe to merge?
There was a problem hiding this comment.
This is a pretty minor change, the main feature (the emails) are gated so this doesn't matter so much.
eliykat
approved these changes
Jan 23, 2025
…ice-approval-requests
…ice-approval-requests
r-tome
deleted the
ac/pm-15637/admin-email-notification-for-device-approval-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15637
📔 Objective
This PR adds
deepLinkGuardto theOrganizationsModuleto enable deep linking for device approval email notification links. This ensures users can directly navigate to the appropriate page when clicking on the links from their email notifications.Server PR.
📸 Screenshots
Screen.Recording.2025-01-15.at.15.50.08.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes