Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace toBeTrue() with toBe(true) #12893

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

audreyality
Copy link
Member

๐ŸŽŸ๏ธ Tracking

n/a

๐Ÿ“” Objective

Fix broken unit tests merged in e79dab8. The tests are broken because the toBeTrue() checker was removed.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner January 15, 2025 16:38
@audreyality audreyality enabled auto-merge (squash) January 15, 2025 16:44
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 3d29463a-15c3-4a8f-b6c6-d0aa69e7c722

Great job, no security vulnerabilities found in this Pull Request

@audreyality audreyality merged commit 58bd44f into main Jan 15, 2025
72 checks passed
@audreyality audreyality deleted the tools/extensions/fix-broken-unit-tests branch January 15, 2025 16:49
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.37%. Comparing base (f6f4bc9) to head (92d639f).
Report is 4 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12893      +/-   ##
==========================================
+ Coverage   34.29%   34.37%   +0.07%     
==========================================
  Files        2935     2952      +17     
  Lines       90237    90448     +211     
  Branches    16945    16974      +29     
==========================================
+ Hits        30951    31088     +137     
- Misses      56822    56896      +74     
  Partials     2464     2464              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants