Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8634] - CLI - return updated folder when saving a folder #12894

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jan 15, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8634

📔 Objective

This PR updates the folder save function to return the updated folder to allow the editFolder to return the updated folder to the client.

📸 Screenshots

403936255-b150f1ca-cd48-4ce6-826a-1e5248609fe7

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 15, 2025 17:08
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb3ae302b-18e2-4ae3-b737-a9c5e34278c1

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.36%. Comparing base (6f018e1) to head (b42394d).
Report is 55 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/cli/src/commands/edit.command.ts 0.00% 3 Missing ⚠️
...on/src/vault/services/folder/folder-api.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12894      +/-   ##
==========================================
+ Coverage   34.27%   34.36%   +0.08%     
==========================================
  Files        2935     2952      +17     
  Lines       90232    90460     +228     
  Branches    16943    16977      +34     
==========================================
+ Hits        30931    31088     +157     
- Misses      56837    56908      +71     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nick-livefront nick-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-16 at 9 56 13 AM

@jaasen-livefront
Copy link
Collaborator Author

@nick-livefront Thanks for the screenshot! I added to the description.

@jaasen-livefront jaasen-livefront merged commit 457aa07 into main Jan 17, 2025
85 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-8634 branch January 17, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants