[PM-12036] Removing ActiveUserState from vault-onboarding.service.ts

[cd-bitwarden]

🎟️ Tracking

📔 Objective

Use SingleUserState not ActiveUserState in vault-onboarding.service

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 7fe1c22e-6cd2-4068-bc69-90607cdfc63a

New Issues (11)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CVE-2024-12381	Npm-electron-33.2.1	Vulnerable Package
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html: 1	details The value used in fido2PopoutSessionData$ at /apps/browser/src/autofill/popup/fido2/fido2-use-browser-link-v1.component.html in line 1 may throw an... Attack Vector
	CVE-2024-11110	Npm-electron-33.2.1	Vulnerable Package
	CVE-2024-11117	Npm-electron-33.2.1	Vulnerable Package
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15	details Method at line 15 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html sends ... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/autofill/popup/settings/autofill-v1.component.ts: 104	details Method AutofillV1Component at line 104 of /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts sends user information outside the app... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/autofill/popup/settings/notifications-v1.component.ts: 32	details Method ngOnInit at line 32 of /apps/browser/src/autofill/popup/settings/notifications-v1.component.ts sends user information outside the applicatio... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/autofill/popup/settings/autofill-v1.component.ts: 104	details Method AutofillV1Component at line 104 of /apps/browser/src/autofill/popup/settings/autofill-v1.component.ts sends user information outside the app... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12	details Method app_fido2_cipher_row_v1 at line 12 of /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts sends user information outside... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12	details Method app_fido2_cipher_row_v1 at line 12 of /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts sends user information outside... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts: 12	details Method app_fido2_cipher_row_v1 at line 12 of /apps/browser/src/autofill/popup/fido2/fido2-cipher-row-v1.component.ts sends user information outside... Attack Vector

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-apps-dialog.component.html: 15
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 17