Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15938] - don't allow 'except password' permissions to view or copy hidden fields #12899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15938

๐Ÿ“” Objective

This PR removes the visibility toggle and copy buttons from hidden fields in the view modal as well as disables the input in the edit modal for except passwords permissions.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 79f8e90c-f6d1-42a6-820f-8fde081929bf

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.34%. Comparing base (99937e5) to head (dc28356).
Report is 2 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...omponents/custom-fields/custom-fields.component.ts 50.00% 0 Missing and 1 partial โš ๏ธ
...r-view/custom-fields/custom-fields-v2.component.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12899      +/-   ##
==========================================
- Coverage   34.34%   34.34%   -0.01%     
==========================================
  Files        2965     2965              
  Lines       90533    90536       +3     
  Branches    16977    16978       +1     
==========================================
+ Hits        31094    31095       +1     
- Misses      56975    56976       +1     
- Partials     2464     2465       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant