Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-256] Update Figma links in Storybook docs #12901

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielleflinn
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/CL-256

๐Ÿ“” Objective

updated existing Figma links to point to the new file and added Figma links to components missing them

Components still missing links to be added:
โ€ข Disclosure pattern
โ€ข Icon component
โ€ข Layout
โ€ข No items
โ€ข Section
โ€ข Popup layout

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

updated existing Figma links to point to the new file and added Figma links to components missing them
@danielleflinn danielleflinn requested a review from a team as a code owner January 16, 2025 01:39
@danielleflinn danielleflinn marked this pull request as draft January 16, 2025 01:42
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ a6bdc14d-28c5-4aac-8482-00435a39d935

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Please upload report for BASE (main@ffa5afb). Learn more about missing BASE report.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12901   +/-   ##
=======================================
  Coverage        ?   34.33%           
=======================================
  Files           ?     2965           
  Lines           ?    90533           
  Branches        ?    16977           
=======================================
  Hits            ?    31087           
  Misses          ?    56982           
  Partials        ?     2464           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant