Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17113] Fix system authentication setup #12907

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jan 16, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17113

📔 Objective

Fixes the logic for determining when biometrics needs to be set-up. On linux, biometrics is "HardwareUnavailable" if no password service is available to store the key. We cannot detect actual hardware availability, and allow system password fallback anyways.

If the password service is available, only then do we check the status of the biometrics policy - whether it was set up - and give back the appropriate status.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner January 16, 2025 11:19
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc5eac7ef-cac5-4ed2-a3c6-65b185dc7a77

Great job, no security vulnerabilities found in this Pull Request

mzieniukbw
mzieniukbw previously approved these changes Jan 16, 2025
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to me

@quexten quexten requested a review from mzieniukbw January 16, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants