Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-17068 -add mdx path to lit main file - Add button docs #12912

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-17068

๐Ÿ“” Objective

Create relevant Docs for StoryBook components

๐Ÿ“ธ Screenshots

Screenshot 2025-01-16 at 10 41 28โ€ฏAM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this Jan 16, 2025
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 8e7409ad-b73b-4363-96a3-b126522fa29d

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.45%. Comparing base (99937e5) to head (b6b7934).
Report is 16 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12912      +/-   ##
==========================================
+ Coverage   34.34%   34.45%   +0.11%     
==========================================
  Files        2965     2974       +9     
  Lines       90533    90666     +133     
  Branches    16977    16989      +12     
==========================================
+ Hits        31094    31240     +146     
+ Misses      56975    56960      -15     
- Partials     2464     2466       +2     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant