Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move premium component into billing ownership #12927

Merged

Conversation

djsmith85
Copy link
Contributor

📔 Objective

Moves the premium.component from vault into billing ownership

Changes

  • Move premium component into billing ownership - 10220f8
    • Update CODEOWNERS
    • Move files within libs/angular
    • Move files within desktop
    • Adjust import paths
  • Remove conditional for extension refresh feature flag - 6294a41

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Update CODEOWNERS
Move files within libs/angular
Move files within desktop
Adjust import paths
@djsmith85 djsmith85 requested review from a team as code owners January 17, 2025 10:30
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Logo
Checkmarx One – Scan Summary & Details55a25609-8c40-4cd8-a71b-3ba32f1b4d4a

Great job, no security vulnerabilities found in this Pull Request

@djsmith85 djsmith85 force-pushed the billing/pm-xxxx/Move-premium-component-into-billing-ownership branch from 6294a41 to 78954a4 Compare January 17, 2025 10:41
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.26%. Comparing base (a04dd7a) to head (abd7009).
Report is 30 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ngular/src/billing/components/premium.component.ts 0.00% 2 Missing ⚠️
...src/billing/popup/settings/premium-v2.component.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/app.component.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/app.module.ts 0.00% 1 Missing ⚠️
...ktop/src/billing/app/accounts/premium.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12927      +/-   ##
==========================================
+ Coverage   35.24%   35.26%   +0.01%     
==========================================
  Files        2997     2997              
  Lines       90886    90877       -9     
  Branches    16973    16968       -5     
==========================================
+ Hits        32034    32046      +12     
+ Misses      56364    56335      -29     
- Partials     2488     2496       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ing/pm-xxxx/Move-premium-component-into-billing-ownership
@djsmith85 djsmith85 enabled auto-merge (squash) January 29, 2025 16:07
@djsmith85 djsmith85 merged commit e73cb3e into main Jan 29, 2025
86 of 87 checks passed
@djsmith85 djsmith85 deleted the billing/pm-xxxx/Move-premium-component-into-billing-ownership branch January 29, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants