Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17346] Move A11yTitle and CopyClick to CL #12936

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17346

📔 Objective

Moves App11yTitle and CopyClick to libs/components. Note this keeps the app namespace, do we want to rename these? Unfortunately I suspect we have to do a bit rename since we depend on the directive name to get the inputs.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners January 17, 2025 16:42
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc0edada9-cdf8-45f1-8a2d-5994417aaaf5

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.97%. Comparing base (83802fc) to head (3db1bca).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12936      +/-   ##
==========================================
+ Coverage   34.32%   34.97%   +0.65%     
==========================================
  Files        2976     2978       +2     
  Lines       90529    90531       +2     
  Branches    16954    16951       -3     
==========================================
+ Hits        31076    31666     +590     
+ Misses      56997    56412     -585     
+ Partials     2456     2453       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vleague2 vleague2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with leaving the names as is for now. We can rename them later

@Hinton Hinton changed the title Move A11yTitle and CopyClick to CL [PM-17346] Move A11yTitle and CopyClick to CL Jan 20, 2025
@Hinton Hinton merged commit d820bfb into main Jan 20, 2025
89 checks passed
@Hinton Hinton deleted the arch/cl-a11y-title-copy-click branch January 20, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants