PM-14223: LoadUrl via messaging #12988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (13)Checkmarx found the following issues in this Pull Request
|
|
@coroiu What do you think about this approach? |
coroiu
reviewed
Jan 21, 2025
| @@ -331,6 +332,10 @@ const routes: Routes = [ | |||
| children: [{ path: "", component: LoginDecryptionOptionsComponent }], | |||
| }, | |||
| ), | |||
| { | |||
| path: "passkeys", | |||
There was a problem hiding this comment.
nit: just to be consistent with naming scheme https://contributing.bitwarden.com/architecture/deep-dives/passkeys/naming-convention
Suggested change
| path: "passkeys", | |
| path: "fido2", |
Comment on lines
38
to
+42
| async onMessage(message: any) { | ||
| switch (message.command) { | ||
| case "loadurl": | ||
| await this.main.windowMain.loadUrl(message.url, message.modal); | ||
| break; |
There was a problem hiding this comment.
issue: using messaging increases the size of this already big class, I would instead suggest taking advantage of IPC requests directly. For an example checkout out clipboard.main.ts and platform/preload.ts. Should be a pretty simple refactor :)
|
Closing in favour of: #13051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes