Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15402] Remove TaxInfoComponent from trial-initiation.module.ts #12996

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jan 21, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15402

📔 Objective

  • Removes TaxInfoComponent from the trial initiation procedure. This allows the old component to be dropped in a subsequent pull request.
  • Adds the Tax ID field to the trial initiation wizard as required for plans that are for business use.

📸 Screenshots

image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Logo
Checkmarx One – Scan Summary & Details04a7391b-f829-4b2f-ae4d-a0bee3e3e6ca

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /libs/common/src/services/api.service.ts: 230
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Cx14b19a02-387a Npm-body-parser-1.20.3

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 35.14%. Comparing base (0974838) to head (3be75f6).
Report is 38 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/trial-initiation/trial-billing-step.component.ts 16.66% 10 Missing ⚠️
...p/auth/trial-initiation/trial-initiation.module.ts 0.00% 1 Missing ⚠️
...rc/app/admin-console/providers/providers.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12996      +/-   ##
==========================================
- Coverage   35.15%   35.14%   -0.01%     
==========================================
  Files        2984     2984              
  Lines       90539    90539              
  Branches    16947    16947              
==========================================
- Hits        31827    31821       -6     
- Misses      56251    56257       +6     
  Partials     2461     2461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jonashendrickx jonashendrickx added the needs-qa Marks a PR as requiring QA approval label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants