Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14952] - restoring item in individual vault results in error #13001

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jan 21, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14952

📔 Objective

This PR fixes an issue where restoring items in the individual vault trash would result in an error. This was due to the fact the restore function was being called from another component and this wasn't bound to it. Changing to an arrow function accomplishes this.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 21, 2025 23:20
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa05782d8-2848-4a26-8bda-f7b6f95724f8

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (e2629ee) to head (94af720).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13001      +/-   ##
==========================================
- Coverage   35.16%   35.15%   -0.01%     
==========================================
  Files        2984     2984              
  Lines       90519    90520       +1     
  Branches    16940    16940              
==========================================
- Hits        31827    31820       -7     
- Misses      56231    56239       +8     
  Partials     2461     2461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaasen-livefront jaasen-livefront changed the title [PM-14952] - change to arrow function to maintain bindings [PM-14952] - restoring item in individual vault results in error Jan 21, 2025
@jaasen-livefront jaasen-livefront merged commit 5600bc0 into main Jan 22, 2025
41 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-14952-2 branch January 22, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants