Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom eslint rule package with enforced using rule #13009

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Jan 22, 2025

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Logo
Checkmarx One – Scan Summary & Details680c9de2-bb4c-473f-80fe-535b197a20f9

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2025-0611 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0612 Npm-electron-33.3.1 Vulnerable Package
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Cx14b19a02-387a Npm-body-parser-1.20.3

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (coroiu/improved-sdk-referencing@3256c1f). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                        Coverage Diff                         @@
##             coroiu/improved-sdk-referencing   #13009   +/-   ##
==================================================================
  Coverage                                   ?   35.17%           
==================================================================
  Files                                      ?     2985           
  Lines                                      ?    90538           
  Branches                                   ?    16943           
==================================================================
  Hits                                       ?    31846           
  Misses                                     ?    56231           
  Partials                                   ?     2461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu changed the title Improved sdk referencing eslint rule Add custom eslint rule package with enforced using rule Jan 24, 2025
@coroiu coroiu marked this pull request as ready for review January 24, 2025 10:57
@coroiu coroiu requested a review from a team as a code owner January 24, 2025 10:57
@coroiu coroiu requested a review from dani-garcia January 24, 2025 10:57
@coroiu coroiu merged commit 4edcc06 into coroiu/improved-sdk-referencing Jan 24, 2025
86 checks passed
@coroiu coroiu deleted the coroiu/improved-sdk-referencing-eslint-rule branch January 24, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant