[PM-17465] refactor PolicyService.getAll$ to make userId not optional

[BTreston]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17465

📔 Objective

Fixes an issue where the PolicyService.getAll$ accepts an optional userId param that is passed to the OrganizationService call that requires a userId, resulting in cases where we pass undefined to the OrganizationService call.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 77f2d436-b2df-4340-864a-cc0ebdba5573

Great job, no security vulnerabilities found in this Pull Request

[amorask-bitwarden]

Billing changes look good, thank you.

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 35.10%. Comparing base (caf3e77) to head (906a280).
Report is 18 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...-form/components/options/send-options.component.ts	0.00%	6 Missing ⚠️
...p/billing/settings/sponsoring-org-row.component.ts	37.50%	5 Missing ⚠️
libs/angular/src/tools/send/add-edit.component.ts	0.00%	3 Missing ⚠️
...p/billing/services/free-families-policy.service.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #13031    +/-   ##
========================================
  Coverage   35.10%   35.10%            
========================================
  Files        2990     3000    +10     
  Lines       91078    91332   +254     
  Branches    17052    17095    +43     
========================================
+ Hits        31974    32065    +91     
- Misses      56611    56762   +151     
- Partials     2493     2505    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eliykat]

This makes a nice start on removing activeUserState from this service :D

[eliykat]

Much nicer, thanks!

[djsmith85]

Approving for Tools