[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #13032

amorask-bitwarden · 2025-01-23T16:56:14Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11730

📔 Objective

This PR removes the Stripe Sources API Deprecation feature flag as well as the older components (now unused) that were utilizing the deprecated API.

Commits are orderly to provide guidance on removal steps.

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

…sources-api

github-actions · 2025-01-23T17:04:46Z

Checkmarx One – Scan Summary & Details – 27cde1e4-15c7-4dd0-a282-10094ab08660

Fixed Issues (80)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 110
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Privacy_Violation	/apps/web/src/app/vault/individual-vault/view.component.ts: 84
	Client_Hardcoded_Domain	/apps/web/src/app/billing/shared/payment/payment.component.ts: 75
	Client_Hardcoded_Domain	/apps/web/src/app/billing/shared/payment/payment.component.ts: 75

codecov · 2025-01-23T17:08:36Z

Codecov Report

Attention: Patch coverage is 8.16327% with 270 lines in your changes missing coverage. Please review.

Project coverage is 35.23%. Comparing base (eb64a0f) to head (aa743dd).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...pp/billing/individual/premium/premium.component.ts	0.00%	72 Missing ⚠️
...rc/app/billing/shared/payment/payment.component.ts	9.67%	54 Missing and 2 partials ⚠️
...-payment-dialog/adjust-payment-dialog.component.ts	15.62%	51 Missing and 3 partials ⚠️
...-storage-dialog/adjust-storage-dialog.component.ts	16.12%	25 Missing and 1 partial ⚠️
...ling/organizations/change-plan-dialog.component.ts	0.00%	24 Missing ⚠️
...ling/organizations/organization-plans.component.ts	0.00%	10 Missing ⚠️
...s/trial-initiation/trial-billing-step.component.ts	25.00%	6 Missing ⚠️
.../billing/individual/user-subscription.component.ts	0.00%	5 Missing ⚠️
...tions/organization-subscription-cloud.component.ts	0.00%	5 Missing ⚠️
...nt-method/organization-payment-method.component.ts	0.00%	4 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13032      +/-   ##
==========================================
+ Coverage   35.10%   35.23%   +0.13%     
==========================================
  Files        3000     2996       -4     
  Lines       91332    90849     -483     
  Branches    17095    16968     -127     
==========================================
- Hits        32065    32014      -51     
+ Misses      56762    56348     -414     
+ Partials     2505     2487      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…sources-api

Patrick-Pimentel-Bitwarden

Few comments. Looks mostly great though!

apps/web/src/app/billing/individual/premium/premium.component.ts

apps/web/src/app/billing/organizations/organization-plans.component.ts

apps/web/src/app/billing/shared/adjust-payment-dialog/adjust-payment-dialog.component.ts

apps/web/src/app/billing/shared/adjust-storage-dialog/adjust-storage-dialog.component.html

apps/web/src/app/billing/shared/adjust-storage-dialog/adjust-storage-dialog.component.ts

apps/web/src/app/billing/shared/payment/payment.component.html

…sources-api

Patrick-Pimentel-Bitwarden

Looks good 👍 Thank you for the good work.

amorask-bitwarden added 16 commits January 23, 2025 09:12

Remove FF from trial-billing-step.component

7ef5cfe

Remove FF from user-subscription.component

b3fc5d5

Remove FF from individual-billing-routing.module

a62d83a

Remove FF from organization-billing.service

14fb8ba

Remove FF from organization-subscription-cloud.component

f1333b3

Remove FF from organization-billing-routing.mdoule

708f2e7

Remove FF from organization-plans.component

c495f98

Remove FF from change-plan-dialog.component

069b124

Remove FF

4eb0a36

Remove legacy payment.component

ebd5531

Rename V2: adjust-payment-dialog.component

076e204

Rename V2: adjust-storage-dialog.component

03961ea

Rename V2: payment-label.component

29455ad

Rename V2: payment.component

acf1d23

Rename V2: premium.component

0638232

Merge branch 'main' into billing/PM-11730/remove-ff-deprecate-stripe-…

b41b51a

…sources-api

amorask-bitwarden marked this pull request as ready for review January 23, 2025 16:57

amorask-bitwarden requested review from a team as code owners January 23, 2025 16:57

amorask-bitwarden requested a review from Patrick-Pimentel-Bitwarden January 23, 2025 16:57

jonashendrickx previously approved these changes Jan 23, 2025

View reviewed changes

Merge branch 'main' into billing/PM-11730/remove-ff-deprecate-stripe-…

4ea27e1

…sources-api

Patrick-Pimentel-Bitwarden reviewed Jan 24, 2025

View reviewed changes

amorask-bitwarden added 2 commits January 24, 2025 10:39

Merge branch 'main' into billing/PM-11730/remove-ff-deprecate-stripe-…

626117c

…sources-api

Patrick's feedback

aa743dd

amorask-bitwarden dismissed jonashendrickx’s stale review via aa743dd January 24, 2025 15:41

amorask-bitwarden requested review from Patrick-Pimentel-Bitwarden and jonashendrickx January 24, 2025 15:45

Patrick-Pimentel-Bitwarden approved these changes Jan 24, 2025

View reviewed changes

cturnbull-bitwarden approved these changes Jan 24, 2025

View reviewed changes

amorask-bitwarden merged commit f630ee5 into main Jan 24, 2025
87 checks passed

amorask-bitwarden deleted the billing/PM-11730/remove-ff-deprecate-stripe-sources-api branch January 24, 2025 18:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #13032

[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #13032

amorask-bitwarden commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading

Patrick-Pimentel-Bitwarden left a comment •

edited

Loading

Patrick-Pimentel-Bitwarden left a comment

[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #13032

[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #13032

Conversation

amorask-bitwarden commented Jan 23, 2025 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

github-actions bot commented Jan 23, 2025 • edited Loading

codecov bot commented Jan 23, 2025 • edited Loading

Codecov Report

Patrick-Pimentel-Bitwarden left a comment • edited Loading

Choose a reason for hiding this comment

Patrick-Pimentel-Bitwarden left a comment

Choose a reason for hiding this comment

amorask-bitwarden commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading

Patrick-Pimentel-Bitwarden left a comment •

edited

Loading