Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17451] Add missing keys for ssh fields to web/en/messages.json #13047

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17451

📔 Objective

Add missing keys to en/messages.json so they are displayed on the new SSH-key add/edit screen

📸 Screenshots

Before After
image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team January 24, 2025 10:15
@djsmith85 djsmith85 enabled auto-merge (squash) January 24, 2025 10:15
@djsmith85 djsmith85 linked an issue Jan 24, 2025 that may be closed by this pull request
1 task
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6561a25d-3f6a-48c6-85a2-0b9dc648639d

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.10%. Comparing base (4cbace9) to head (c4be910).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13047   +/-   ##
=======================================
  Coverage   35.10%   35.10%           
=======================================
  Files        3000     3000           
  Lines       91320    91320           
  Branches    17094    17094           
=======================================
  Hits        32062    32062           
  Misses      56754    56754           
  Partials     2504     2504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@djsmith85 djsmith85 merged commit bd0607b into main Jan 24, 2025
39 of 40 checks passed
@djsmith85 djsmith85 deleted the vault/pm-17451/headings-missing-from-ssh-key-fields branch January 24, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headings missing from SSH key fields
2 participants