[PM-17541] Fix folder service key definition #13060
Merged
+148
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration script for users that have switched to the incorrect key
justindbaur
requested changes
Jan 24, 2025
libs/common/src/state-migrations/migrations/69-migrate-incorrect-folder-key.spec.ts
Outdated
Show resolved
Hide resolved
justindbaur
previously approved these changes
Jan 24, 2025
gbubemismith
previously approved these changes
Jan 24, 2025
|
Great job, no security vulnerabilities found in this Pull Request |
|
@shane-melton I think there are some type check issues |
Jingo88
previously approved these changes
Jan 24, 2025
Probably because the test doesn't have: like the test you based it on. Feel free to add it or fix the issue, I'll approve either. |
shane-melton
dismissed stale reviews from Jingo88, gbubemismith, and justindbaur
via
d943361
justindbaur
approved these changes
Jan 24, 2025
gbubemismith
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13060 +/- ##
==========================================
+ Coverage 35.10% 35.12% +0.01%
==========================================
Files 3000 3001 +1
Lines 91332 91349 +17
Branches 17095 17097 +2
==========================================
+ Hits 32065 32082 +17
Misses 56762 56762
Partials 2505 2505 ☔ View full report in Codecov by Sentry. |
shane-melton
added a commit
that referenced
this pull request
Jan 24, 2025
* [PM-17541] Switch folder key definition back to "folders" and add migration script for users that have switched to the incorrect key * [PM-17541] Fix import path * [PM-17541] Fix implicit any in spec file (cherry picked from commit b1744c4)
shane-melton
added a commit
that referenced
this pull request
Jan 24, 2025
* [PM-17541] Switch folder key definition back to "folders" and add migration script for users that have switched to the incorrect key * [PM-17541] Fix import path * [PM-17541] Fix implicit any in spec file (cherry picked from commit b1744c4)
shane-melton
added a commit
that referenced
this pull request
Jan 24, 2025
* [PM-17541] Switch folder key definition back to "folders" and add migration script for users that have switched to the incorrect key * [PM-17541] Fix import path * [PM-17541] Fix implicit any in spec file (cherry picked from commit b1744c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17541
📔 Objective
Update the
FOLDER_ENCRYPTED_FOLDERSkey definition key back tofoldersand write a migration script to revert any users that may have updated to thefolderkey.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes