Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test disabled binding on input directive #13086

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willmartian
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse05211f5-23ff-4dc7-b451-2265673bb280

New Issues (42)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2024-12692 Npm-electron-33.3.1 Vulnerable Package
CRITICAL CVE-2024-12694 Npm-electron-33.3.1 Vulnerable Package
CRITICAL CVE-2024-12695 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11112 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11113 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11114 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11115 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11395 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12053 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12381 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12382 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12693 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0291 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0434 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0436 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0437 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0438 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0443 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0447 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11110 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11111 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11116 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11117 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0435 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0439 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0440 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0441 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0442 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0446 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0448 Npm-electron-33.3.1 Vulnerable Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 50
detailsMethod at line 50 of /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts sends user infor...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/admin-console/components/collections.component.ts: 36
detailsMethod at line 36 of /libs/angular/src/admin-console/components/collections.component.ts sends user information outside the application. This may ...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 119
detailsMethod at line 119 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may constitute...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 286
detailsMethod load at line 286 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may consti...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 780
detailsMethod loadAddEditCipherInfo at line 780 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 50
detailsMethod OpenAttachmentsComponent at line 50 of /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.compo...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 70
detailsMethod at line 70 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may constitute ...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 278
detailsMethod load at line 278 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may consti...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 281
detailsMethod load at line 281 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may consti...
Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 776
detailsMethod loadAddEditCipherInfo at line 776 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application...
Attack Vector
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 75
detailsThe JavaScript file imported in "https://js\.stripe\.com/v3/?advancedFraudSignals=false" in /apps/web/src/app/billing/shared/payment/payment.componen...
Attack Vector
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 75
detailsThe JavaScript file imported in "https://js\.stripe\.com/v3/?advancedFraudSignals=false" in /apps/web/src/app/billing/shared/payment/payment.componen...
Attack Vector

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.25%. Comparing base (e2629ee) to head (7d89ba2).
Report is 73 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13086      +/-   ##
==========================================
+ Coverage   35.16%   35.25%   +0.09%     
==========================================
  Files        2984     2997      +13     
  Lines       90519    90889     +370     
  Branches    16940    16974      +34     
==========================================
+ Hits        31827    32044     +217     
- Misses      56231    56356     +125     
- Partials     2461     2489      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant