-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pm-17363] Add LimitItemDeletion property to models #13087
base: main
Are you sure you want to change the base?
Conversation
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #13087 +/- ##
=======================================
Coverage 35.36% 35.37%
=======================================
Files 3010 3010
Lines 91156 91160 +4
Branches 16995 16995
=======================================
+ Hits 32237 32247 +10
+ Misses 56421 56415 -6
Partials 2498 2498 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auth files look good.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17363
📔 Objective
Add the
LimitItemDeletion
property to client models that handle organization settings.📸 Screenshots
spot check testing
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes