Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17610] Remove getUserId operator #13091

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

BTreston
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-17610

๐Ÿ“” Objective

This PR fixes the error that gets thrown by the getUserId custom rxjs operator in instances where we rely on null/undefined being unhandled.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner January 27, 2025 17:14
@BTreston BTreston requested a review from dani-garcia January 27, 2025 17:14
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.28%. Comparing base (146939b) to head (920f271).
Report is 1 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/common/src/platform/sync/default-sync.service.ts 0.00% 2 Missing โš ๏ธ
libs/common/src/platform/sync/core-sync.service.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13091   +/-   ##
=======================================
  Coverage   35.28%   35.28%           
=======================================
  Files        2997     2997           
  Lines       90873    90871    -2     
  Branches    16966    16966           
=======================================
  Hits        32067    32067           
+ Misses      56318    56316    -2     
  Partials     2488     2488           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@BTreston BTreston merged commit da422fd into main Jan 27, 2025
85 of 86 checks passed
@BTreston BTreston deleted the ac/pm-17610-remove-getUserId-operator branch January 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants