Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17629] Split up KM lib to km and km-ui #13093

Merged
merged 8 commits into from
Jan 30, 2025
Merged

[PM-17629] Split up KM lib to km and km-ui #13093

merged 8 commits into from
Jan 30, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 27, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17629

📔 Objective

Split KM team into km and km-ui.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners January 27, 2025 18:14
@Hinton Hinton requested a review from justindbaur January 27, 2025 18:14
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Logo
Checkmarx One – Scan Summary & Details4f93c2ea-ec80-477d-aab5-b1e6f8447444

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html: 19
detailsMethod weak_passwords_report_component at line 19 of /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html sends user informat...
Attack Vector

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this needs to be added to tailwind configs like we did here https://github.com/bitwarden/clients/pull/12783/files.

Also CI jobs are failing, but might just need latest main merged.

@Hinton Hinton requested a review from Thomas-Avery January 28, 2025 08:37
@Hinton Hinton requested a review from a team as a code owner January 28, 2025 08:37
@Hinton Hinton requested a review from merissaacosta January 28, 2025 08:37
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.43%. Comparing base (582beaf) to head (c82d3f9).
Report is 24 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/popup/app-routing.module.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/app-routing.module.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/services/services.module.ts 0.00% 1 Missing ⚠️
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13093      +/-   ##
==========================================
+ Coverage   35.30%   35.43%   +0.13%     
==========================================
  Files        2997     2995       -2     
  Lines       90882    90638     -244     
  Branches    16969    16898      -71     
==========================================
+ Hits        32085    32121      +36     
+ Misses      56310    56025     -285     
- Partials     2487     2492       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from Thomas-Avery January 28, 2025 15:48
@merissaacosta merissaacosta requested review from vleague2 and removed request for merissaacosta January 28, 2025 16:25
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hinton Hinton merged commit f8bdd66 into main Jan 30, 2025
86 checks passed
@Hinton Hinton deleted the arch/split-km-ui branch January 30, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants