-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17629] Split up KM lib to km and km-ui #13093
Conversation
New Issues (1)Checkmarx found the following issues in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this needs to be added to tailwind configs like we did here https://github.com/bitwarden/clients/pull/12783/files.
Also CI jobs are failing, but might just need latest main merged.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13093 +/- ##
==========================================
+ Coverage 35.30% 35.43% +0.13%
==========================================
Files 2997 2995 -2
Lines 90882 90638 -244
Branches 16969 16898 -71
==========================================
+ Hits 32085 32121 +36
+ Misses 56310 56025 -285
- Partials 2487 2492 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17629
📔 Objective
Split KM team into km and km-ui.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes