-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17120] account deprovisioning banner #13097
base: main
Are you sure you want to change the base?
Conversation
New Issues (3)Checkmarx found the following issues in this Pull Request
Fixed Issues (8)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13097 +/- ##
==========================================
+ Coverage 35.28% 35.39% +0.10%
==========================================
Files 2997 3010 +13
Lines 90871 91183 +312
Branches 16966 17000 +34
==========================================
+ Hits 32067 32275 +208
- Misses 56316 56400 +84
- Partials 2488 2508 +20 ☔ View full report in Codecov by Sentry. |
|
||
async hideBanner(organization: Organization) { | ||
await this._showBanner.update((state) => { | ||
if (!state) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add tests here. Abstracting this into a pure function will reduce test setup effort.
(state) => {
if (!state) {
state = [organization.id];
} else if (!state.includes(organization.id)) {
state.push(organization.id);
}
return state;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Just one suggestion.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17120
https://bitwarden.atlassian.net/browse/PM-17151
📔 Objective
This PR adds a new banner to display to owners and admins that they may now delete member accounts that belong to a claimed domain. Also addresses subtask to remove the Provider banner.
📸 Screenshots
Screen.Recording.2025-01-27.at.3.09.01.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes