-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17168] Sync organization user revoked/restored status immediately via push notification #13101
Open
r-tome
wants to merge
10
commits into
main
Choose a base branch
from
ac/pm-17168/revoking-user-is-not-synced-immediately-via-push-notification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[PM-17168] Sync organization user revoked/restored status immediately via push notification #13101
r-tome
wants to merge
10
commits into
main
from
ac/pm-17168/revoking-user-is-not-synced-immediately-via-push-notification
+39
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wait for reconnect
… in a separate method
…diately-via-push-notification
…OrgKeysOnRevokeRestore
r-tome
changed the title
[PM17168] Sync organization user revoked/restored status immediately via push notification
[PM-17168] Sync organization user revoked/restored status immediately via push notification
Jan 28, 2025
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #13101 +/- ##
==========================================
- Coverage 35.29% 35.28% -0.02%
==========================================
Files 2997 2997
Lines 90882 90891 +9
Branches 16969 16971 +2
==========================================
- Hits 32080 32074 -6
- Misses 56314 56329 +15
Partials 2488 2488 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17168
📔 Objective
This PR updates the
NotificationsService
to handle messages of typeNotificationType.SyncOrgKeys
by refreshing the identity token.I also noticed that the SignalR connection stops when receiving a
NotificationType.SyncOrgKeys
message but does not restart automatically. To fix this, I updated the reconnect method to re-setup the connection.Server PR.
📸 Screenshots
Revoking and restoring a user a couple of times:
Screen.Recording.2025-01-28.at.12.41.05.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes