Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17592]Remove feature flag Disable free families sponsorship #13102

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17592

📔 Objective

Remove feature flag Disable free families sponsorship

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested review from a team as code owners January 28, 2025 15:03
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Logo
Checkmarx One – Scan Summary & Details3791ac61-760d-48b3-85aa-e0fc8e1ada4a

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 35.30%. Comparing base (582beaf) to head (b779f36).
Report is 76 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/billing/settings/sponsored-families.component.ts 0.00% 8 Missing ⚠️
...p/billing/settings/sponsoring-org-row.component.ts 0.00% 4 Missing ⚠️
...p/billing/services/free-families-policy.service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13102      +/-   ##
==========================================
- Coverage   35.30%   35.30%   -0.01%     
==========================================
  Files        2997     2997              
  Lines       90882    90864      -18     
  Branches    16969    16964       -5     
==========================================
- Hits        32085    32075      -10     
+ Misses      56310    56302       -8     
  Partials     2487     2487              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 removed the request for review from willmartian January 29, 2025 16:34
@cyprain-okeke cyprain-okeke merged commit 586cbcc into main Feb 5, 2025
86 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-17592-remove-feature-flag-disable-free-families-sponsorship branch February 5, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants