[PM-17590] fix chrome translation bug by escaping $
#13103
+11
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17590
📔 Objective
Fix a translation bug affecting Chrome browser.
Chrome removes invalid interpolation keys in its messages.json translations. This caused the generator on chromium browsers to render
!@#$%^&*
as!@#^&*
. Unfortunately, theI18nService
used by the web and desktop code renders$$
when properly escaping the i18n string. Thus, the solution is to hard-code the value.Angular string interpolation is used as the fix because the entity escape sequence for
@
looks like line noise.This PR also removes unused translation keys as to avoid confusion in the future.
📸 Screenshots
Before:
After:
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes