Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17655] Billing Code Ownership Updates #13105

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

cturnbull-bitwarden
Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden commented Jan 28, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17655

📔 Objective

Moving billing-related code to be under our ownership.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details26e7480f-ca1a-4996-b338-a48220086e72

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.32%. Comparing base (70ea75d) to head (3f5fe61).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...illing/trial-initiation/trial-initiation.module.ts 0.00% 3 Missing ⚠️
apps/web/src/app/oss-routing.module.ts 0.00% 2 Missing ⚠️
...bout-page/more-from-bitwarden-page-v2.component.ts 0.00% 1 Missing ⚠️
...-initiation/complete-trial-initiation.component.ts 0.00% 1 Missing ⚠️
apps/web/src/app/oss.module.ts 0.00% 1 Missing ⚠️
...eb/src/app/tools/reports/reports-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13105   +/-   ##
=======================================
  Coverage   35.32%   35.32%           
=======================================
  Files        2998     2998           
  Lines       90922    90922           
  Branches    16979    16979           
=======================================
  Hits        32114    32114           
  Misses      56316    56316           
  Partials     2492     2492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cturnbull-bitwarden cturnbull-bitwarden changed the title [PM-17655] Billing Code Ownership Updates [PM-17655] chore: Billing Code Ownership Updates Jan 28, 2025
@cturnbull-bitwarden cturnbull-bitwarden changed the title [PM-17655] chore: Billing Code Ownership Updates [PM-17655] Billing Code Ownership Updates Jan 28, 2025
Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved vault changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

Copy link
Member

@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Tools code LGTM!

@cturnbull-bitwarden cturnbull-bitwarden merged commit 26a0594 into main Jan 28, 2025
90 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/PM-17655/code-ownership branch January 28, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants