-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17619] Add Intial Windows WebAuthn Plugin Authenticator Bindings Crate #13112
base: main
Are you sure you want to change the base?
Conversation
Fixed Issues (7)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13112 +/- ##
==========================================
- Coverage 35.37% 35.37% -0.01%
==========================================
Files 3010 3010
Lines 91176 91176
Branches 16996 16996
==========================================
- Hits 32258 32251 -7
- Misses 56412 56419 +7
Partials 2506 2506 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why not make this a crate inside desktop_native
? That way you'll be able to piggyback on the existing NAPI stuff when it's time to start integrating with electron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it there initially but took it out, hoping to conditionally include the crate as a dependency only if the target is Windows. (Which you can't conditionally do within a workspace, as you already know. Link for posterity.)
Maybe I should add it back though, so it will be an included "empty" crate with cfg, just to follow the existing convention.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17619
📔 Objective
This adds the crate which will interop with the Windows WebAuthn Plugin Authenticator API's. There is much more to add, this is just the initial placement.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes