Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17619] Add Intial Windows WebAuthn Plugin Authenticator Bindings Crate #13112

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

coltonhurst
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17619

📔 Objective

This adds the crate which will interop with the Windows WebAuthn Plugin Authenticator API's. There is much more to add, this is just the initial placement.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Logo
Checkmarx One – Scan Summary & Details5af8664d-cb72-43cc-992e-70fcc5aced39

Fixed Issues (7)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/autofill/popup/fido2/fido2-use-browser-link.component.html: 1
MEDIUM Client_Privacy_Violation /libs/vault/src/components/totp-countdown/totp-countdown.component.ts: 17
MEDIUM Client_Privacy_Violation /libs/vault/src/components/totp-countdown/totp-countdown.component.ts: 16
LOW Client_DOM_Open_Redirect /apps/web/src/app/billing/shared/payment-method.component.ts: 155
LOW Client_DOM_Open_Redirect /apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts: 187
LOW Client_DOM_Open_Redirect /apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts: 155
LOW Client_DOM_Open_Redirect /apps/web/src/app/billing/shared/payment-method.component.ts: 183

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.37%. Comparing base (db2b405) to head (18acf4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13112      +/-   ##
==========================================
- Coverage   35.37%   35.37%   -0.01%     
==========================================
  Files        3010     3010              
  Lines       91176    91176              
  Branches    16996    16996              
==========================================
- Hits        32258    32251       -7     
- Misses      56412    56419       +7     
  Partials     2506     2506              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why not make this a crate inside desktop_native? That way you'll be able to piggyback on the existing NAPI stuff when it's time to start integrating with electron

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it there initially but took it out, hoping to conditionally include the crate as a dependency only if the target is Windows. (Which you can't conditionally do within a workspace, as you already know. Link for posterity.)

Maybe I should add it back though, so it will be an included "empty" crate with cfg, just to follow the existing convention.

@coltonhurst coltonhurst requested a review from a team as a code owner January 29, 2025 16:08
@coltonhurst coltonhurst requested a review from coroiu January 29, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants