[PM-17688] - generator dialog - add missing button label i18n keys. fix logic for disabling button #13140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaasen-livefront
requested review from
gbubemismith and
audreyality
and removed request for
gbubemismith
|
Great job, no security vulnerabilities found in this Pull Request |
audreyality
previously approved these changes
Jan 29, 2025
apps/desktop/src/vault/app/vault/credential-generator-dialog.component.ts
Outdated
Show resolved
Hide resolved
libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.html
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13140 +/- ##
==========================================
+ Coverage 35.37% 35.38% +0.01%
==========================================
Files 3010 3010
Lines 91176 91150 -26
Branches 16996 16983 -13
==========================================
+ Hits 32251 32254 +3
+ Misses 56419 56394 -25
+ Partials 2506 2502 -4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: ✨ Audrey ✨ <[email protected]>
|
@audreyality Thanks for the quick review! I updated the comment which dismissed your approval. Would you mind re-approving? Thanks! |
audreyality
approved these changes
Jan 29, 2025
gbubemismith
approved these changes
Jan 29, 2025
audreyality
added a commit
that referenced
this pull request
Jan 30, 2025
…ix logic for disabling button (#13140) * add missing button label i18n keys. fix logic for displaying button label * Update comment Co-authored-by: ✨ Audrey ✨ <[email protected]> --------- Co-authored-by: ✨ Audrey ✨ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17688
📔 Objective
This PR fixes an issue with missing i18n keys for the username generator dialog. It also adds some logic for disabling the action button if the user hasn't selected an algorithm and/or generated a value.
📸 Screenshots
Screen.Recording.2025-01-29.at.12.50.07.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes