Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17170] Added retry logic when mounting Stripe elements and extended timout to 50 ms #13142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17170

📔 Objective

Added retry logic when mounting Stripe elements and extended timout to 50 ms

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team as a code owner January 29, 2025 20:57
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details096400d9-5b24-4347-af9a-5dbe83b4fdec

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.38%. Comparing base (ef38a96) to head (66966c5).

Files with missing lines Patch % Lines
...pps/web/src/app/billing/services/stripe.service.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13142   +/-   ##
=======================================
  Coverage   35.37%   35.38%           
=======================================
  Files        3010     3010           
  Lines       91148    91153    +5     
  Branches    16982    16983    +1     
=======================================
+ Hits        32247    32254    +7     
+ Misses      56399    56397    -2     
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cturnbull-bitwarden cturnbull-bitwarden changed the title Added retry logic when mounting Stripe elements and extended timout to 50 ms [PM-17170] Added retry logic when mounting Stripe elements and extended timout to 50 ms Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants