Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pm-17763] Add the limitItemDeletion property to the UI checkbox #13162

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

JimmyVo16
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17763

📔 Objective

  1. Add the limitItemDeletion property to the UI checkbox.
  2. Only display the new checkbox if the feature flag pm-15493-restrict-item-deletion-to-can-manage-permission` is on.

📸 Screenshots

testing.for.limit.item.deletion.mov

when the feature is off, it just sends back the original data it got from the server

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JimmyVo16 JimmyVo16 requested a review from a team as a code owner January 30, 2025 18:10
@JimmyVo16 JimmyVo16 requested a review from jrmccannon January 30, 2025 18:10
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc61592a6-4b6d-4ffc-a43d-09281d85e1bd

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (cbba1a6) to head (bc5c00a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...onsole/organizations/settings/account.component.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13162   +/-   ##
=======================================
  Coverage   35.48%   35.49%           
=======================================
  Files        3007     3007           
  Lines       90872    90879    +7     
  Branches    16904    16905    +1     
=======================================
+ Hits        32250    32258    +8     
+ Misses      56120    56119    -1     
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmyVo16 JimmyVo16 merged commit 7a1121d into main Jan 30, 2025
86 checks passed
@JimmyVo16 JimmyVo16 deleted the ac/pm-17763/add-limt-item-deletion-to-ui branch January 30, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants