-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15126] Third attempt: Remove reliance on secrets in build pipelines #13222
Conversation
…ipelines-to-remove-reliance-on-secrets
…ipelines-to-remove-reliance-on-secrets
@justindbaur adding you as reviewer too because of how highly discussed this has been |
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13222 +/- ##
==========================================
- Coverage 35.21% 35.20% -0.01%
==========================================
Files 3126 3126
Lines 92567 92567
Branches 16857 16857
==========================================
- Hits 32597 32590 -7
- Misses 57513 57520 +7
Partials 2457 2457 ☔ View full report in Codecov by Sentry. |
I'd say this is blocked from merging until bitwarden/renovate-config#18 is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about passing inputs, otherwise everything looks good.
pull_request_target are only intended to be used with contributor PRs and we cannot dispatch builds for these branches so there was no point having that option.
This is a re-introduction of the original PR. The following is the original description:
📔 Objective
This PR changes how our CI workflows run so that they are able to run even without secrets. It also adds another another set of workflows that can be manually triggered by Bitwarden employees to build contributor PRs with full access to secrets if needed.
build-<app>.yml
workflows now run onpull_request
instead ofpull_request_target
, this means that:build-<app>-target.yml
have been added to let Bitwarden employees manually triggerbuild-<app>.yml
usingpull_request_target
which gives it access to all the secretsbuild-<app>.yml
but with full inherited secretsHere is an example of these workflows running in a fork: coroiu#1
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes