[PM-8951] set pin validation to min length of 4 #13312
Open
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13312 +/- ##
==========================================
+ Coverage 35.29% 35.31% +0.02%
==========================================
Files 3124 3128 +4
Lines 92483 92600 +117
Branches 16818 16826 +8
==========================================
+ Hits 32638 32702 +64
- Misses 57388 57438 +50
- Partials 2457 2460 +3 ☔ View full report in Codecov by Sentry. |
kspearrin
changed the title
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
JaredSnider-Bitwarden
requested changes
Feb 13, 2025
Thanks for the feedback. Those suggestions make a lot of sense. Done. |
|
JaredSnider-Bitwarden
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8951
📔 Objective
Users should not be able to set a PIN with a length less than 4.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes