Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typescript-transform-paths config #13400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Feb 14, 2025

🎟️ Tracking

N/A

📔 Objective

typescript-transform-paths was already removed as a dependency but the config was never removed. It has been replaced by tsconfig-paths-webpack-plugin.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This was already removed as a dependency and has been superseded by
tsconfig-paths-webpack-plugin. The config was never removed.
@eliykat eliykat requested a review from Hinton February 14, 2025 03:03
@eliykat eliykat requested a review from a team as a code owner February 14, 2025 03:03
@eliykat eliykat requested a review from addisonbeck February 14, 2025 03:03
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.33%. Comparing base (a5d0451) to head (df7c261).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13400   +/-   ##
=======================================
  Coverage   35.33%   35.33%           
=======================================
  Files        3130     3130           
  Lines       92592    92592           
  Branches    16809    16809           
=======================================
  Hits        32713    32713           
  Misses      57438    57438           
  Partials     2441     2441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd83b6682-b1c6-42bb-8843-a94c6fad974c

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants