Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-include Electron updates with Renovate #6602

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Re-include Electron updates with Renovate #6602

merged 1 commit into from
Oct 17, 2023

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Oct 17, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Track Electron updates. Should help with awareness and we'll get security-focused PRs opened by the tool should they come up. Doesn't mean we use and merge the PR if it doesn't catch the builder reference, but I think it helps.

Related to #6511 and #6573.

Code changes

  • .github/renovate.json: Package exclusion removals.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Oct 17, 2023
@withinfocus withinfocus marked this pull request as ready for review October 17, 2023 00:20
@withinfocus withinfocus requested a review from a team as a code owner October 17, 2023 00:20
@withinfocus withinfocus removed the needs-qa Marks a PR as requiring QA approval label Oct 17, 2023
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – 83ddad20-57b1-455c-bb58-da447714466c

Fixed Issues

Severity Issue Source File / Package
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 60
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 58
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 61
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 37
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 30
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/safeincloud-xml-importer.ts: 24
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 23
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/clipperz-html-importer.ts: 17
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/passwordsafe-xml-importer.ts: 17
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/passky/passky-json-importer.ts: 22

Hinton
Hinton reviewed Oct 17, 2023
View reviewed changes
.github/renovate.json
"ignoreDeps": [
"@types/koa-bodyparser",
"bootstrap",
"electron-builder",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful with electron-builder, the version state sometimes differs and GH reports them as pre-releases while npm as stable.

@withinfocus withinfocus merged commit d4e6793 into master Oct 17, 2023
@withinfocus withinfocus deleted the electron-renovate branch October 17, 2023 12:15
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
@withinfocus @BlackDex
Re-include Electron updates with Renovate (bitwarden#6602)
e193fa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@withinfocus @bitwarden-bot @Hinton