Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-6413] Add http loophole for localhost #9236

Merged
merged 7 commits into from
Jun 25, 2024
Merged

[PM-6413] Add http loophole for localhost #9236

merged 7 commits into from
Jun 25, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented May 17, 2024

Fixes #6882

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Check if hostname is localhost and skip https requirement.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@coroiu coroiu requested a review from a team as a code owner May 17, 2024 15:41
@coroiu coroiu requested a review from justindbaur May 17, 2024 15:41
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 17, 2024
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.79%. Comparing base (18b56c0) to head (691299a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9236   +/-   ##
=======================================
  Coverage   28.78%   28.79%           
=======================================
  Files        2503     2503           
  Lines       72855    72857    +2     
  Branches    13581    13583    +2     
=======================================
+ Hits        20970    20976    +6     
+ Misses      50274    50272    -2     
+ Partials     1611     1609    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 96fccd41-01a3-4fcd-b485-faae48c654eb

No New Or Fixed Issues Found

@coroiu coroiu requested a review from justindbaur June 7, 2024 08:14
justindbaur
justindbaur previously approved these changes Jun 7, 2024
View reviewed changes
@coroiu coroiu mentioned this pull request Jun 10, 2024
Closed
1 task
@coroiu coroiu requested a review from a team as a code owner June 10, 2024 13:49
@coroiu coroiu requested a review from gbubemismith June 10, 2024 13:49
@coroiu coroiu requested a review from a team as a code owner June 10, 2024 13:55
@coroiu coroiu requested review from cagonzalezcs and removed request for gbubemismith and a team June 10, 2024 13:56
cagonzalezcs
cagonzalezcs approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@cagonzalezcs cagonzalezcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid from my side.

@coroiu coroiu requested a review from justindbaur June 17, 2024 12:08
@coroiu coroiu removed the needs-qa Marks a PR as requiring QA approval label Jun 25, 2024
@coroiu coroiu merged commit dce5c0f into main Jun 25, 2024
63 of 66 checks passed
@coroiu coroiu deleted the PM-6413-add-http-loophole-for-localhost branch June 25, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justindbaur justindbaur justindbaur approved these changes

@cagonzalezcs cagonzalezcs cagonzalezcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebAuthN fails on localhost because it expects an HTTPS origin
3 participants
@coroiu @cagonzalezcs @justindbaur