Clarify instructions for local SAML SSO #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ca30c95
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b982ad7.contributing-docs.pages.dev |
| Branch Preview URL: | https://update-local-saml-config.contributing-docs.pages.dev |
|
No New Or Fixed Issues Found |
JaredSnider-Bitwarden
approved these changes
Feb 2, 2024
djsmith85
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
With bitwarden/clients#7117, we added an SSO configuration option (defaulting to enabled) that creates a specific Entity ID in the URL.
In the setup documentation, the URL didn't reflect that change. Despite the instructions to copy from the values in the web client, the presence of the "copy" UI made it very easy to copy the incorrect URL and set the environment variable incorrectly.
Instead of adding "{yourOrgIdHere}" as was already in the ACS URL, I opted to completely remove any reference to the URLs themselves in the script, so that users will use the values in the UI. This will prevent us from having to keep the documentation in sync with any future URL structure changes.