Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/safari instructions #383

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix/safari instructions #383

merged 2 commits into from
Jul 10, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jul 10, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Update the contributing docs to include updated instructions for safari. Specifically the location for the index.html seemed out of date, and for safari we need to build for manifest v2.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner July 10, 2024 16:24
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 095ada3e-9946-4452-abe8-03fd13b41be4

No New Or Fixed Issues Found

@quexten quexten merged commit 440bf8a into main Jul 10, 2024
7 checks passed
@quexten quexten deleted the fix/safari-instructions branch July 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants